Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - "loaded via URL" should show full URL #16

Open
agrover opened this issue Jun 12, 2020 · 2 comments
Open

Feature request - "loaded via URL" should show full URL #16

agrover opened this issue Jun 12, 2020 · 2 comments

Comments

@agrover
Copy link

agrover commented Jun 12, 2020

Is your feature request related to a problem? Please describe.
I've loaded a qlog by url. I want to send a link to the qlog, but once it's loaded there's no place I can see to cut and paste the original loaded URL. (Yes, maybe it's still in my paste buffer, or I could go back to wherever I got it from, but....Qvis shows "loaded via URL" in many places, which is SO CLOSE, but these are all abbreviated e.g. "https://blah.net/qlog/...3636298364.qlog" not the actual correct URL

Describe the solution you'd like
Either show the entire URL so I can cut and paste, or make it a link with the full original URL.

Describe alternatives you've considered
It would also be nice if there was a way to send a colleague a qvis link that included the qlog URL to load. Even better still would be if packets in the sequence were anchors so the URL could reference a specific packet in a sequence for my colleague to look at.

@rmarx
Copy link
Member

rmarx commented Jul 1, 2020

Hello Andy,

Sorry for the late reply, though I did see the issue earlier.

Showing full .qlog links is a good feature that shouldn't be too much work to add.

There are some caveats here though, in that it's more difficult if the user didn't pass in a .qlog directly (e.g., do we link to the passed-in .pcap file? What about the .keys file then?). Ideally, I'd store the qlog on the server and let people link to that, but I'm not sure I want to offer that service as part of qvis... Similar questions can be asked when passing multiple qlog files at once.

So I'll probably add the simplest case soon (if you passed in a .qlog URL, you'll get to extract that easily) and keep the rest for later.

I will also look into the "jump to a specific part of the sequence diagram via the URL" concept, which is something I'd considered before and agree would be very useful.

rmarx added a commit that referenced this issue Jul 3, 2020
rmarx added a commit that referenced this issue Jul 3, 2020
…am. Link is shown in the event modal popup after click.

- Another partial fix for #16
@rmarx
Copy link
Member

rmarx commented Jul 3, 2020

Hello Andy,

I have updated qvis to hopefully fix most of the issue for you.

Firstly, if the qlog was loaded from a URL directly, the URL is now click-able in the sequence diagram (should be underlined and clickable on top of the vertical timelines). This works for 2 sides separately (client vs server) if both were loaded from a URL individually).

Secondly, if you now click on an event in the sequence diagram to get the popup with extra qlog details (so click on one of the colored squares for example), there should now be a link on top that you can copy. This link should open qvis directly with the given trace and scroll automatically to the specified event. An example of such a link (which should scroll all the way down to packet 367) is: https://qvis.edm.uhasselt.be/?#/sequence?file=https://qlog.edm.uhasselt.be/anrw/files/examples/figure2_c.qlog&focusOnConnection=0&focusOnEvent=5869

For this second part there are some caveats though:

  1. only works if the trace was loaded via a URL
  2. it doesn't highlight or indicate the chosen event directly, it just makes sure it's "on screen". I guess that's ok for most purposes, so let me know what a better UX solution would be for this if not.
  3. if you've loaded 2 traces separately, this will generate a single link that combines them + also scrolls to the correct event. However, due to another bug in qlog, you need to manually select the server-side trace (currently, it auto-generates another viewpoint from the client trace). Fill file this as a separate bug after this post.

Please try it out and let me know if you'd like changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants