Skip to content

Commit

Permalink
Merge pull request #3963 from larseggert/nt-to-not
Browse files Browse the repository at this point in the history
n't -> not
  • Loading branch information
martinthomson committed Aug 4, 2020
2 parents d1d4fb1 + 7ba50f4 commit 3d49aa6
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 19 deletions.
6 changes: 3 additions & 3 deletions draft-ietf-quic-http.md
Expand Up @@ -1622,7 +1622,7 @@ H3_NO_ERROR (0x100):
there is no error to signal.

H3_GENERAL_PROTOCOL_ERROR (0x101):
: Peer violated protocol requirements in a way that doesn't match a more
: Peer violated protocol requirements in a way that does not match a more
specific error code, or endpoint declines to use the more specific error code.

H3_INTERNAL_ERROR (0x102):
Expand Down Expand Up @@ -1713,7 +1713,7 @@ signal that this is acceptable. Coordinating when such a revised layout comes
into effect could prove complex. As such, allocating new identifiers for
new definitions of existing protocol elements is likely to be more effective.

This document doesn't mandate a specific method for negotiating the use of an
This document does not mandate a specific method for negotiating the use of an
extension but notes that a setting ({{settings-parameters}}) could be used for
that purpose. If both peers set a value that indicates willingness to use the
extension, then the extension can be used. If a setting is used for extension
Expand Down Expand Up @@ -1803,7 +1803,7 @@ All these features -- i.e., server push, unknown protocol elements, field
compression -- have legitimate uses. These features become a burden only when
they are used unnecessarily or to excess.

An endpoint that doesn't monitor this behavior exposes itself to a risk of
An endpoint that does not monitor this behavior exposes itself to a risk of
denial-of-service attack. Implementations SHOULD track the use of these
features and set limits on their use. An endpoint MAY treat activity that is
suspicious as a connection error ({{errors}}) of type H3_EXCESSIVE_LOAD, but
Expand Down
4 changes: 2 additions & 2 deletions draft-ietf-quic-invariants.md
Expand Up @@ -87,7 +87,7 @@ new versions are developed and deployed. All of these invariants are
IP-version-independent.

The primary goal of this document is to ensure that it is possible to deploy new
versions of QUIC. By documenting the properties that can't change, this
versions of QUIC. By documenting the properties that cannot change, this
document aims to preserve the ability for QUIC endpoints to negotiate changes to
any other aspect of the protocol. As a consequence, this also guarantees a
minimal amount of information that is made available to entities other than
Expand Down Expand Up @@ -244,7 +244,7 @@ The remainder of the packet has version-specific semantics.
A connection ID is an opaque field of arbitrary length.

The primary function of a connection ID is to ensure that changes in addressing
at lower protocol layers (UDP, IP, and below) don't cause packets for a QUIC
at lower protocol layers (UDP, IP, and below) do not cause packets for a QUIC
connection to be delivered to the wrong QUIC endpoint. The connection ID
is used by endpoints and the intermediaries that support them to ensure that
each QUIC packet can be delivered to the correct instance of an endpoint. At
Expand Down
6 changes: 3 additions & 3 deletions draft-ietf-quic-qpack.md
Expand Up @@ -685,7 +685,7 @@ either unidirectional stream type MUST be treated as a connection error of type
H3_CLOSED_CRITICAL_STREAM.

An endpoint MAY avoid creating an encoder stream if it's not going to be used
(for example if its encoder doesn't wish to use the dynamic table, or if the
(for example if its encoder does not wish to use the dynamic table, or if the
maximum size of the dynamic table permitted by the peer is zero).

An endpoint MAY avoid creating a decoder stream if its decoder sets the maximum
Expand Down Expand Up @@ -1308,7 +1308,7 @@ used. If HPACK is used for re-encoding, the never indexed literal
representation (see Section 6.2.3 of [RFC7541]) MUST be used.

The choice to mark that a header field should never be indexed
depends on several factors. Since QPACK doesn't protect against guessing an
depends on several factors. Since QPACK does not protect against guessing an
entire header field value, short or low-entropy values are more readily
recovered by an adversary. Therefore, an encoder might choose not to index
values with low entropy.
Expand Down Expand Up @@ -1577,7 +1577,7 @@ for line in field_lines:
dynamicIndex = dynamicTable.add(line)

if dynamicIndex is None:
# Couldn't index it, literal
# Could not index it, literal
if nameIndex is None or isStaticName:
# Encodes a literal with a static name or literal name
encodeLiteral(streamBuffer, nameIndex, line)
Expand Down
2 changes: 1 addition & 1 deletion draft-ietf-quic-recovery.md
Expand Up @@ -929,7 +929,7 @@ interval = smoothed_rtt * packet_size / congestion_window / N
~~~

Using a value for `N` that is small, but at least 1 (for example, 1.25) ensures
that variations in round-trip time don't result in under-utilization of the
that variations in round-trip time do not result in under-utilization of the
congestion window. Values of 'N' larger than 1 ultimately result in sending
packets as acknowledgments are received rather than when timers fire, provided
the congestion window is fully utilized and acknowledgments arrive at regular
Expand Down
21 changes: 11 additions & 10 deletions draft-ietf-quic-transport.md
Expand Up @@ -474,9 +474,10 @@ These state machines shown in this section are largely informative. This
document uses stream states to describe rules for when and how different types
of frames can be sent and the reactions that are expected when different types
of frames are received. Though these state machines are intended to be useful
in implementing QUIC, these states aren't intended to constrain implementations.
An implementation can define a different state machine as long as its behavior
is consistent with an implementation that implements these states.
in implementing QUIC, these states are not intended to constrain
implementations. An implementation can define a different state machine as long
as its behavior is consistent with an implementation that implements these
states.

Note:

Expand Down Expand Up @@ -1042,7 +1043,7 @@ selected by endpoints; each endpoint selects the connection IDs that its peer
uses.

The primary function of a connection ID is to ensure that changes in addressing
at lower protocol layers (UDP, IP) don't cause packets for a QUIC
at lower protocol layers (UDP, IP) do not cause packets for a QUIC
connection to be delivered to the wrong endpoint. Each endpoint selects
connection IDs using an implementation-specific (and perhaps
deployment-specific) method that will allow packets with that connection ID to
Expand Down Expand Up @@ -1230,7 +1231,7 @@ resulted in changes to the state of a connection that cannot be reverted.
Valid packets sent to clients always include a Destination Connection ID that
matches a value the client selects. Clients that choose to receive
zero-length connection IDs can use the local address and port to identify a
connection. Packets that don't match an existing connection are discarded.
connection. Packets that do not match an existing connection are discarded.

Due to packet reordering or loss, a client might receive packets for a
connection that are encrypted with a key it has not yet computed. The client MAY
Expand Down Expand Up @@ -2530,8 +2531,8 @@ A client might wish to reduce linkability by employing a new connection ID and
source UDP port when sending traffic after a period of inactivity. Changing the
UDP port from which it sends packets at the same time might cause the packet to
appear as a connection migration. This ensures that the mechanisms that support
migration are exercised even for clients that don't experience NAT rebindings or
genuine migrations. Changing port number can cause a peer to reset its
migration are exercised even for clients that do not experience NAT rebindings
or genuine migrations. Changing port number can cause a peer to reset its
congestion state (see {{migration-cc}}), so the port SHOULD only be changed
infrequently.

Expand Down Expand Up @@ -2855,7 +2856,7 @@ To support this process, a token is sent by endpoints. The token is carried in
the Stateless Reset Token field of a NEW_CONNECTION_ID frame. Servers can also
specify a stateless_reset_token transport parameter during the handshake that
applies to the connection ID that it selected during the handshake; clients
cannot use this transport parameter because their transport parameters don't
cannot use this transport parameter because their transport parameters do not
have confidentiality protection. These tokens are protected by encryption, so
only client and server know their value. Tokens are invalidated when their
associated connection ID is retired via a RETIRE_CONNECTION_ID frame
Expand Down Expand Up @@ -6065,7 +6066,7 @@ type of 0x1c is used to signal errors at only the QUIC layer, or the absence of
errors (with the NO_ERROR code). The CONNECTION_CLOSE frame with a type of 0x1d
is used to signal an error with the application that uses QUIC.

If there are open streams that haven't been explicitly closed, they are
If there are open streams that have not been explicitly closed, they are
implicitly closed when the connection is closed.

The CONNECTION_CLOSE frames are shown in {{fig-connection-close}}.
Expand Down Expand Up @@ -7071,7 +7072,7 @@ DecodePacketNumber(largest_pn, truncated_pn, pn_nbits):
// expected_pn - pn_hwin and less than or equal to
// expected_pn + pn_hwin
//
// This means we can't just strip the trailing bits from
// This means we cannot just strip the trailing bits from
// expected_pn and add the truncated_pn because that might
// yield a value outside the window.
//
Expand Down

0 comments on commit 3d49aa6

Please sign in to comment.