Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hq Alt-Svc quic parameter and structured headers #1093

Closed
LPardue opened this issue Feb 2, 2018 · 6 comments
Closed

hq Alt-Svc quic parameter and structured headers #1093

LPardue opened this issue Feb 2, 2018 · 6 comments
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@LPardue
Copy link
Member

LPardue commented Feb 2, 2018

I think the current syntax of the "quic" parameter for hq Alt-Svc is, after recent changes, incompatible with structured headers. For reference, httpwg/http-extensions#281 provides history of the issue. This ticket highlights that HTTP/QUIC is now incompatible.

Please close this out if a non-issue.

@MikeBishop
Copy link
Contributor

Technically, it's a non-issue, since Alt-Svc isn't defined to be a structured header. However, the goal is to track that draft as closely as reasonable, since it also represents a best practice. I'll take a look and see if there's a simple change that would bring us closer, but I also don't want change for change's sake.

@MikeBishop
Copy link
Contributor

Seems like the simplest choice would be a comma-delimited quoted string, i.e.

quic = DQUOTE version-number [ "," version-number ] * DQUOTE
version-number = 1*8HEXDIG; hex-encoded QUIC version

That certainly makes it shorter and matches the guidance, at the price of updating everyone's parser again. What do folks think?

@MikeBishop MikeBishop added editorial An issue that does not affect the design of the protocol; does not require consensus. -http labels Feb 2, 2018
@LPardue
Copy link
Member Author

LPardue commented Feb 2, 2018

I have no strong stake.

Good point about structured header / best common practice.

@ianswett
Copy link
Contributor

ianswett commented Feb 2, 2018

So, oddly enough GQUIC has already started supporting the newly proposed IETF Alt-Svc, but if we're going to change it, sooner would be better. And if you change it again after this time, we'll probably start getting grumpy :)

But shorter and following best practices seem like general goodness.

@siyengar
Copy link

siyengar commented Feb 2, 2018

+1 on sooner the better.

@janaiyengar
Copy link
Contributor

janaiyengar commented Feb 3, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

5 participants