Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hq: HEADERS frame still refers to HPACK #1161

Closed
LPardue opened this issue Mar 5, 2018 · 0 comments · Fixed by #1162
Closed

hq: HEADERS frame still refers to HPACK #1161

LPardue opened this issue Mar 5, 2018 · 0 comments · Fixed by #1162
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@LPardue
Copy link
Member

LPardue commented Mar 5, 2018

The HEADERS frame incorrectly still refers to HPACK while PUSH_PROMISE says QCRAM.

I intend to create a PR that will fix this issue, and will adopt the common QCRAM naming that can be fixed as a global find/replace at a later date.
LPardue added a commit to LPardue/base-drafts that referenced this issue Mar 5, 2018
@LPardue
Add figures for all HTTP/QUIC frames
82e7fb1 
Fixes quicwg#1158, and a drive-by fix for quicwg#1161.
@LPardue LPardue mentioned this issue Mar 5, 2018
Merged
MikeBishop pushed a commit that referenced this issue Mar 5, 2018
@LPardue @MikeBishop
Add figures for all HTTP/QUIC frames (#1162)
586d1b5 
Fixes #1158, and a drive-by fix for #1161.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -http labels Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add figures for all HTTP/QUIC frames LPardue/base-drafts
2 participants
@martinthomson @LPardue