Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table resize can't be acknowledged #1365

Closed
martinthomson opened this issue May 21, 2018 · 4 comments
Closed

Table resize can't be acknowledged #1365

martinthomson opened this issue May 21, 2018 · 4 comments
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects

Comments

@martinthomson
Copy link
Member

Acknowledgments encode the number of insertions, which is nice because that's what you need to track for other reasons. However, this makes resizing the table invisible and not acknowledged. I think that's OK, but it means that an encoder can't rely on increased space being available until it receives acknowledgment for the next insertion after the resize.

I think that's worth calling out in the description of the Dynamic Table Size Update instruction.

(Marking this design in case someone disagrees with my conclusion.)

@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -qpack labels May 21, 2018
@afrind
Copy link
Contributor

afrind commented May 22, 2018

The inserts and the table size updates all happen on the encoder stream, which is in-order and reliable. Why can't the encoder assume the additional space is available immediately after encoding the table size update?

@MikeBishop
Copy link
Contributor

Indeed, HPACK has no acknowledgements for this. HPACK has acknowledgements (via H2 SETTINGS) for changes in the decoder's maximum table size, but that's mostly immutable in HQ.

@mnot mnot added this to Headers in HTTP May 23, 2018
@afrind
Copy link
Contributor

afrind commented May 25, 2018

@martinthomson : are we good to close this with no-action or you think we could benefit from editorial text explaining the similarity to HPACK in this regard?

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. and removed design An issue that affects the design of the protocol; resolution requires consensus. labels May 27, 2018
@martinthomson
Copy link
Member Author

"I think that's worth calling out in the description of the Dynamic Table Size Update instruction." - just a few words noting that the change isn't important from the perspective of the encoder, so it doesn't get acknowledged, except transitively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
No open projects
HTTP
Headers
Development

No branches or pull requests

3 participants