Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Payload" vs. "content" #1676

Closed
MikeBishop opened this issue Aug 16, 2018 · 1 comment
Closed

"Payload" vs. "content" #1676

MikeBishop opened this issue Aug 16, 2018 · 1 comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@MikeBishop
Copy link
Contributor

@mirjak points out that payload and content are both used to refer to the body of QUIC packets. Worth doing a pass to ensure that these are used consistently. My first pass at definitions:

  • "Payload" is the collection of frames in the encrypted body of the packet.
  • "Content" is the conceptual set of information conveyed by those frames, but probably not something we reference very often in the spec.
@MikeBishop MikeBishop added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Aug 16, 2018
@mirjak
Copy link
Contributor

mirjak commented Aug 16, 2018

Yes, I agree with this definition there might actually only a few cases where its not correct but further I think it would be important to actually define this somewhere explicitly.

Or to say your definition in other words
Payload is the thing in a PACKET that follows the header.
Content is any information or data carried in a FRAME.

@MikeBishop MikeBishop mentioned this issue Aug 16, 2018
Closed
martinthomson added a commit that referenced this issue Aug 27, 2018
@martinthomson
Reconcile 'content' and 'payload'
d6cff09 
I did a complete pass through and it wasn't that bad.  As we agreed,
payload is the bytes that we protect, content is the more abstract
notion of what needs to be communicated (for which we use frames).  That
was already mostly right, apart from a few places.

Closes #1676.
@martinthomson martinthomson mentioned this issue Aug 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeBishop @mirjak