Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text for "half-closed (remote)" #179

Closed
ddragana opened this issue Jan 19, 2017 · 3 comments
Closed

Text for "half-closed (remote)" #179

ddragana opened this issue Jan 19, 2017 · 3 comments
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@ddragana
Copy link
Contributor

A stream that is "half-closed (remote)" is no longer being used by
the peer to send any data. In this state, a sender is no longer
obligated to maintain a receiver stream-level flow-control window.

If an endpoint receives any STREAM frames for a stream that is in
this state, it MUST close the connection with a
QUIC_STREAM_DATA_AFTER_TERMINATION error (Section 11).

If a packet sent before the packet with FIN bit set gets lost and is retransmitted is going to cause close of the connection.
The text needs to change to say if a frame with offset larger than the offset + size of the frame with FIN bit set is received. (or a better wording)

(An editorial remark: In the "Lifecycle of a stream" diagram going from "half-closed(remote)" to "closed" should be cause by "send FIN" not "recv FIN" and from "half-closed(local)" to "closed" should be cause by "recv FIN")

@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -transport labels Jan 19, 2017
@martinthomson
Copy link
Member

Yes, the correct formulation here is: if a STREAM frame containing octets that are greater in offset than the last octet in a closed stream, then the receiver MUST terminate ... A receiver SHOULD retain a last octet value for closed streams for a short period of time after they close. This value is the largest received octet offset if the stream is terminated by a STREAM frame containing a FIN bit; a peer will include this value in a RST_STREAM frame.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. and removed design An issue that affects the design of the protocol; resolution requires consensus. labels Jan 19, 2017
@martinthomson
Copy link
Member

I think that we can keep this editorial.

@martinthomson
Copy link
Member

We've a lot of new text here. If there are any remaining errors, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

2 participants