Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECN counters and Coalescing of QUIC packets #1838

Closed
gloinul opened this issue Oct 7, 2018 · 4 comments
Closed

ECN counters and Coalescing of QUIC packets #1838

gloinul opened this issue Oct 7, 2018 · 4 comments
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@gloinul
Copy link
Contributor

gloinul commented Oct 7, 2018

I realize there exist a need to clarify the text regarding ECN on the relation between IP packets and QUIC packets. As QUIC tracks QUIC packets, and not IP packets, this relation when coaleing occurs needs to be clarified. What I think is needed are:

  • In Section 6.8: Using Explicit Congestion Notification should be updated to be explicit about when it talks about IP packet and when about QUIC packets.
  • State explicitly that for coalesed QUIC packets, the IP packet's ECN field value is reported for each QUIC packet.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Oct 16, 2018
@martinthomson
Copy link
Member

Sounds good. I'm sure that we'd appreciate getting a PR for this.

@gloinul
Copy link
Contributor Author

gloinul commented Oct 17, 2018

So how do we deal with the different packet number spaces here. I see two options:
Either say that we totally ignore Initial packets in the perspective of ECN handling. Which basically delays the ECN verification until one sees ACKs for the 0- or 1-RTT packets. Or one requires one set of counters per packet number space. What are peoples preference here?

@martinthomson
Copy link
Member

I'm thinking that you count separately, in the interests of keeping ACK accounting separate (and consistent). But no special handling, or disabling ECN for different phases. You can still use Initial/Handshake to verify that the path supports ECN.

@ianswett
Copy link
Contributor

Agreed, each PN space has its own set of counters, and an ACK frame sent in a PN space conveys the counters of that PN space.

martinthomson added a commit that referenced this issue Oct 25, 2018
This deals with the distinction between IP and QUIC packets better,
clarifies the interaction with packet coalescing, and makes it clear
that counts are ACK state and therefore separated by packet number
space.

Closes #1838.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

3 participants