Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit retransmission of closing packet #1905

Closed
martinthomson opened this issue Oct 24, 2018 · 0 comments
Closed

Limit retransmission of closing packet #1905

martinthomson opened this issue Oct 24, 2018 · 0 comments
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@martinthomson
Copy link
Member

@mikkelfj observes that we permit rate limiting of connection close frames, but they might be used to create an amplification attack if the closing endpoint is naive in its handling. The fix is easy - the endpoint needs to remember a validated address for its peer along with the closing packet. Packets from other remote addresses need to be dropped or only responded to if the size of the incoming packet is > 1/3 of the closing packet. In most cases, this won't change anything.
@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -transport labels Oct 24, 2018
martinthomson added a commit that referenced this issue Oct 25, 2018
@martinthomson
Don't amplify accidentally when closing
7a9e8e4 
A minor point, and we might not even regret this, but it's not worth
risking it.

Closes #1905.
@martinthomson martinthomson mentioned this issue Oct 25, 2018
Merged
@mnot mnot added the has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinthomson @mnot