Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what is the default dependent stream of pushed streams #1959

Closed
siyengar opened this issue Nov 3, 2018 · 5 comments · Fixed by #2072 or #2074
Closed

what is the default dependent stream of pushed streams #1959

siyengar opened this issue Nov 3, 2018 · 5 comments · Fixed by #2072 or #2074
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus.

Comments

@siyengar
Copy link

siyengar commented Nov 3, 2018

in http/2 the default dependency of the pushed stream was it's associated stream. However in h3 we now have push ids and not associated streams. Should we have a default priority here?

@LPardue
Copy link
Member

LPardue commented Nov 3, 2018

Any PUSH_PROMISE is still triggered by a request and sent back on that bidi stream. Would it suffice to assume that one's priority?

@martinthomson
Copy link
Member

Yes, PUSH_PROMISE can be used, but which PUSH_PROMISE?

The pushed response is what would be prioritized, and multiple requests can point at the same pushed response.

@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -http labels Nov 3, 2018
@LPardue
Copy link
Member

LPardue commented Nov 3, 2018

So I always look at Priortisation from the server's perspective - if it wants to push a thing, how should it assign resources to that thing's response, in keeping with how the client already expressed it's priority preferences.

So in other words, what I said is then: the pushed pseudo-request assumes it's parent request's priority by default. A client could then repriortise that particular pseudo-request by using the PRIORITY frame with the Push ID.

Logically, the reprioritisation would point the dependency at some other request (Stream ID), a different Push promise ID (reprioritising to self means what??), or some placeholder ID.

Now, here's where I get told all my assumption have been wrong :)

@martinthomson
Copy link
Member

I can put the same PUSH_PROMISE (promising the same push) on two request streams. Which of those does the pushed stream depend on?

@LPardue
Copy link
Member

LPardue commented Nov 3, 2018

Good point. The last one?

What about assuming no default priority as a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
3 participants