DUPLICATE_PUSH instead of multiple PUSH_PROMISE frames #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
added
design
draft-ietf-quic-http.md
Outdated
| When a client request is first sent or a placeholder first allocated, the | ||
| element is dependent on the root of the priority tree. Pushed streams are | ||
| initially dependent on the client request on which the PUSH_PROMISE frame was | ||
| sent. In all cases, elements are assigned an initial weight of 16. |
There was a problem hiding this comment.
This is a nice side-effect.
There was a problem hiding this comment.
Moved to #2074 so I could do more priority-related changes without blocking on this, but I agree. :-)
MikeBishop
force-pushed
the
http/duplicate_push
branch
from
fc9a95d
to
69a825d
Compare
dtikhonov
reviewed
Nov 30, 2018
dtikhonov
approved these changes
Nov 30, 2018
LPardue
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1864, by only sending the request headers once and having a separate frame to pick them up by reference.
Also would have fixed #1959 along the way, as an added bonus.(Separated into new PR so I can fix some other PRIORITY things.)However, this is not an unmitigated improvement. The point of the ordering requirement for PUSH_PROMISE frames is that the client knows that a push is coming before they see references to a dependent resource and initiate their own requests. If reordering (or blocking QPACK references) places a DUPLICATE_PUSH ahead of the corresponding PUSH_PROMISE, knowing that the resource is on the way can no longer be guaranteed.