Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need guidance on how often to send BLOCKED #198

Closed
ekr opened this issue Jan 23, 2017 · 1 comment
Closed

Need guidance on how often to send BLOCKED #198

ekr opened this issue Jan 23, 2017 · 1 comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@ekr
Copy link
Collaborator

ekr commented Jan 23, 2017

The present text strongly suggests that I should be sending blocked every time I get new data:

A sender sends a BLOCKED frame (type=0x05) when it is ready to send
data (and has data to send), but is currently flow control blocked.

If the idea is that it should be edge triggered rather than level triggered, the text should say so
@igorlord
Copy link
Contributor

Related issue #65.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Jan 24, 2017
@martinthomson martinthomson mentioned this issue Apr 27, 2017
Closed
martinthomson added a commit that referenced this issue May 8, 2017
@martinthomson
Only allow BLOCKED once per limit
0c6c15a 
Getting this right is tricky because the frame can be "retransmitted" in the
event of loss, but I don't want to use the word "retransmitted".  This would be
a lot easier if we did #452.

Closes #198.
@martinthomson martinthomson mentioned this issue May 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martinthomson @ekr @igorlord