Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are reason phrases potentially 65k long? #199

Closed
ekr opened this issue Jan 23, 2017 · 3 comments
Closed

Why are reason phrases potentially 65k long? #199

ekr opened this issue Jan 23, 2017 · 3 comments
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@ekr
Copy link
Collaborator

ekr commented Jan 23, 2017

There is a two byte length field. Surely a 256-byte reason phrase is long enough.

Also, are these in ASCII? UTF-8?
@igorlord
Copy link
Contributor

There is a related issue #187.

@martinthomson
Copy link
Member

256 octets probably won't carry a stack trace :)

This is entirely proprietary, but we could recommend that text (if it is text) be UTF-8.

@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -transport labels Jan 24, 2017
@marten-seemann
Copy link
Contributor

Since frames cannot be split (except for STREAM frames), there's no way to send more than around 1340 bytes of reason phrase anyway in the general case (IPv6 doesn't support packet fragmentation).

martinthomson added a commit that referenced this issue Apr 27, 2017
@martinthomson
Minor editorial corrections to reason phrase of CONNECTION_CLOSE
4e7d185 
Closes #199.
@martinthomson martinthomson mentioned this issue Apr 27, 2017
Merged
@mnot mnot added the has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. label Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@martinthomson @mnot @ekr @marten-seemann @igorlord