Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packet number space not explained in handshake text #2334

Closed
mikkelfj opened this issue Jan 14, 2019 · 3 comments
Closed

Packet number space not explained in handshake text #2334

mikkelfj opened this issue Jan 14, 2019 · 3 comments
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing

Comments

@mikkelfj
Copy link
Contributor

Sect. 7 in transport refers to packer number spaces without any reference to what that might mean. These are only introduced later in sect. 12.3.

Also the text talks about crypto sequence numbers and the text is not very clear about these being different from packet numbers if you haven't been through TLS text.
@ianswett ianswett added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Jan 15, 2019
@mnot mnot added this to Editorial Issues in Late Stage Processing Feb 27, 2019
@dtikhonov
Copy link
Member

This is still an issue.

I think adding references to Section 12.3 where packet number spaces are mentioned (List of Common Terms and Section 7) would be sufficient.

@ianswett
Copy link
Contributor

Sounds great, would you be willing to write a PR @dtikhonov

dtikhonov pushed a commit to dtikhonov/base-drafts that referenced this issue Jan 29, 2020
Add forward references to packet number spaces
9eee3eb 
Fixes issue quicwg#2334
@dtikhonov dtikhonov mentioned this issue Jan 29, 2020
Merged
@MikeBishop MikeBishop changed the title Packer number space not explained in handshake text Packet number space not explained in handshake text Feb 4, 2020
@MikeBishop
Copy link
Contributor

Fixed in #3401.

Late Stage Processing automation moved this from Editorial Issues to Text Incorporated Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing
  
Issue Handled
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikkelfj @MikeBishop @dtikhonov @ianswett