Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalise HTTP_WRONG_SETTING_DIRECTION error #2810

Closed
LPardue opened this issue Jun 19, 2019 · 3 comments · Fixed by #2814
Closed

Rationalise HTTP_WRONG_SETTING_DIRECTION error #2810

LPardue opened this issue Jun 19, 2019 · 3 comments · Fixed by #2814
Labels

Comments

@LPardue
Copy link
Member

LPardue commented Jun 19, 2019

HTTP_WRONG_SETTING_DIRECTION presently applies to exactly one case, a client that sends NUM_PLACEHOLDERS. Declassifying this as an error seems like a sensible option. This frees up error code 0x1, which we can move HTTP_GENERAL_PROTOCOL_ERROR to (making HTTP/3 more similar to HTTP/2).

My initial preference is to state that servers MUST ignore this value if present. I'll prepare a PR to that effect.

@LPardue LPardue changed the title Suggest removal of HTTP_WRONG_SETTING_DIRECTION error Rationalise HTTP_WRONG_SETTING_DIRECTION error Jun 19, 2019
@LPardue
Copy link
Member Author

LPardue commented Jun 19, 2019

I forgot to mention that @MikeBishop made an observation that SETTINGS errors are presently also covered by MALFORMED_FRAME, which is also on the chopping block.

An alternative solution is therefore to create an INVALID_SETTINGS that covers all the ways that a SETTINGS frames could go wrong.

@kazuho
Copy link
Member

kazuho commented Jun 19, 2019

Thank you for opening the issues.

While I agree that we do not need an error code specific to SETTINGS going in the wrong direction, I am not sure if declassifying it as an error is the right option. Not that I have a strong opinion, but IIRC our consensus is to be more strict against misbehaving peers in HTTP/3 compared to HTTP/2.

MALFORMED_FRAME or INVALID_SETTINGS sounds like a more conservative fix to me.

@LPardue
Copy link
Member Author

LPardue commented Jun 19, 2019

Thanks @kazuho, after suggesting this I changed my mind. I made #2814 to implement the change as you and Mike suggest. The nice side effect is that it takes one step away from MALFORMED_FRAME.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants