New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rationalise HTTP_WRONG_SETTING_DIRECTION error #2810
Comments
I forgot to mention that @MikeBishop made an observation that SETTINGS errors are presently also covered by MALFORMED_FRAME, which is also on the chopping block. An alternative solution is therefore to create an |
Thank you for opening the issues. While I agree that we do not need an error code specific to SETTINGS going in the wrong direction, I am not sure if declassifying it as an error is the right option. Not that I have a strong opinion, but IIRC our consensus is to be more strict against misbehaving peers in HTTP/3 compared to HTTP/2. MALFORMED_FRAME or INVALID_SETTINGS sounds like a more conservative fix to me. |
HTTP_WRONG_SETTING_DIRECTION presently applies to exactly one case, a client that sends NUM_PLACEHOLDERS. Declassifying this as an error seems like a sensible option. This frees up error code 0x1, which we can move HTTP_GENERAL_PROTOCOL_ERROR to (making HTTP/3 more similar to HTTP/2).
My initial preference is to state that servers MUST ignore this value if present. I'll prepare a PR to that effect.
The text was updated successfully, but these errors were encountered: