Rationalize HTTP_WRONG_SETTING_DIRECTION #2814
Conversation
draft-ietf-quic-http.md
Outdated
| HTTP_SETTINGS_ERROR (0x01): | ||
| : An endpoint detected an error with a SETTINGS frame: a duplicate setting was | ||
| detected, a client-only setting was sent by a server, or a server-only setting | ||
| by a client. |
There was a problem hiding this comment.
The suggestion to move HTTP_GENERAL_PROTOCOL_ERROR to 0x01 might be worth taking at the same time, since people are going to change which error to use for these anyway. (Also, I just noticed that GPE is missing from the IANA table.)
There was a problem hiding this comment.
That was my initial intention but I thought it might make life harder. However, life is hard regardless so I'll try it out.
(Also, I just noticed that GPE is missing from the IANA table.)
You reminded me that I fixed this on the MALFORMED_FRAME PR. It makes sense to fix that here though while shuffling things around.
draft-ietf-quic-http.md
Outdated
| @@ -1902,7 +1903,7 @@ The entries in the following table are registered by this document. | |||
| | Name | Code | Description | Specification | | |||
| | ----------------------------------- | ---------- | ---------------------------------------- | ---------------------- | | |||
| | HTTP_NO_ERROR | 0x0000 | No error | {{http-error-codes}} | | |||
| | HTTP_WRONG_SETTING_DIRECTION | 0x0001 | Setting sent in wrong direction | {{http-error-codes}} | | |||
| | HTTP_SETTINGS_ERROR | 0x0001 | Setting duplication or wrong direction | {{http-error-codes}} | | |||
There was a problem hiding this comment.
I'd be more general -- SETTINGS frame contained invalid values, or something like that. It's anything that could go wrong with that frame's payload.
draft-ietf-quic-http.md
Outdated
| : Peer violated protocol requirements in a way which doesn't match a more | ||
| specific error code, or endpoint declines to use the more specific error code. | ||
| HTTP_SETTINGS_ERROR (0x00FF): | ||
| : An endpoint detected an error with a SETTINGS frame: a duplicate setting was |
There was a problem hiding this comment.
Maybe "detected an error in the values found in the payload of a SETTINGS frame"?
I suggest this assuming that HTTP_MALFORMED_FRAME is the error code to be used when seeing a badly-formatted SETTINGS frame (for example a SETTINGS frame carrying one byte of data: 0xff).
There was a problem hiding this comment.
I added you suggestion for payload.
The ultimate goal is to replace MALFORMED_FRAME with FRAME_SIZE_ERROR. That should cover the case you mention. At that point in time we an add some text to suggest which type of error code should be used.
MikeBishop
force-pushed
the
2810-settings-error
branch
from
bb11701
to
49414b9
Compare
This fixes #2810 in a different way by subtituting the error code and not changing the requirements related to NUM_PLACEHOLDERS.
Closes #2811.