Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceeding Max STREAM ID should be a connection error #2825

Closed
ianswett opened this issue Jun 21, 2019 · 5 comments · Fixed by #2826
Closed

Exceeding Max STREAM ID should be a connection error #2825

ianswett opened this issue Jun 21, 2019 · 5 comments · Fixed by #2826
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.

Comments

@ianswett
Copy link
Contributor

In most places in QUIC, if an error is clearly avoidable(ie: only a buggy implementation would do so), then we advise closing the connection with an error, not just closing the stream with an error.

In section 4.5 of transport(https://tools.ietf.org/html/draft-ietf-quic-transport-20#section-4.5) it says:
"Endpoints MUST NOT exceed the limit set by their peer. An endpoint
that receives a STREAM frame with a stream ID exceeding the limit it
has sent MUST treat this as a stream error of type STREAM_LIMIT_ERROR"

Came up in discussion of #2730

@ianswett
Copy link
Contributor Author

As I commented in the updated PR description, section 19.11 already says this:
"An endpoint MUST terminate a connection
with a STREAM_LIMIT_ERROR error if a peer opens more streams than was
permitted."

@mnot mnot added this to Triage in Late Stage Processing Jun 24, 2019
Late Stage Processing automation moved this from Triage to Text Incorporated Jun 26, 2019
@martinthomson martinthomson reopened this Jun 26, 2019
Late Stage Processing automation moved this from Text Incorporated to Triage Jun 26, 2019
@martinthomson
Copy link
Member

Reopening to keep this visible.

@mnot mnot added the design An issue that affects the design of the protocol; resolution requires consensus. label Jun 27, 2019
@mnot
Copy link
Member

mnot commented Jun 27, 2019

#2826 is effectively the proposal, correct?

@mnot mnot moved this from Triage to Design Issues in Late Stage Processing Jun 27, 2019
@martinthomson
Copy link
Member

Yes. It was editorial. So I merged it. But then this issue really isn't editorial.

@ianswett
Copy link
Contributor Author

Yes, I opened this issue, then found that text in section 19.11 in the doc said exceeding MAX_STREAM_ID was a connection error, so the PR ended up aligning the two sections.

@mnot mnot added the proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. label Jul 1, 2019
@mnot mnot moved this from Design Issues to Consensus Emerging in Late Stage Processing Jul 1, 2019
@mnot mnot moved this from Consensus Emerging to Consensus Call issued in Late Stage Processing Aug 6, 2019
@mnot mnot moved this from Consensus Call issued to Consensus Declared in Late Stage Processing Aug 16, 2019
@mnot mnot added has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list. and removed proposal-ready An issue which has a proposal that is believed to be ready for a consensus call. labels Aug 16, 2019
Late Stage Processing automation moved this from Consensus Declared to Text Incorporated Aug 16, 2019
@juliens juliens mentioned this issue Oct 12, 2019
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport design An issue that affects the design of the protocol; resolution requires consensus. has-consensus An issue that the Chairs have determined has consensus, by canvassing the mailing list.
Projects
Late Stage Processing
  
Issue Handled
Development

Successfully merging a pull request may close this issue.

3 participants