Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Incorrect offset in sample -tls #3279

Closed
slightlyfloating opened this issue Dec 2, 2019 · 0 comments
Closed

Issue: Incorrect offset in sample -tls #3279

slightlyfloating opened this issue Dec 2, 2019 · 0 comments

Comments

@slightlyfloating
Copy link

slightlyfloating commented Dec 2, 2019

I believe the sample given in https://tools.ietf.org/html/draft-ietf-quic-tls-24#appendix-A.2
contains an incorrect offset to the packet number field,

Considering the 22-byte long header given in the sample
c3 ff000017 08 8394c8f03e515708 00 00 449e 00000002
I think the following line
header[17..20] ^= mask[1..4]
is supposed to read:
header[18..21] ^= mask[1..4]
as the 4-byte packet number (0x00000002) actually starts at offset 18 (0-based) of the header.

@slightlyfloating slightlyfloating changed the title Issue: Incorrect offset in sample Issue: Incorrect offset in sample -tls Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant