Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language in recommendations for ack-range limits #3316

Closed
janaiyengar opened this issue Jan 1, 2020 · 1 comment · Fixed by #3315
Closed

Fix language in recommendations for ack-range limits #3316

janaiyengar opened this issue Jan 1, 2020 · 1 comment · Fixed by #3315
Assignees
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@janaiyengar
Copy link
Contributor

In trying to do a simple fix for #3311, I found other irrelevant or poorly-written recommendations in how a receiver could limit ACK ranges it sends. This section needs to be rewritten.

Specifically, the sentence below is a poor recommendation and contradicts earlier recommendation on acking until the ACK frame is acknowledged.

   The receiver SHOULD
   exclude already acknowledged packets from future ACK frames whenever
   these packets would unnecessarily contribute to the ACK frame size.

The recommendation below is fine, but the rationale does not make sense:

   Standard QUIC algorithms ([QUIC-RECOVERY]) declare
   packets lost after sufficiently newer packets are acknowledged.
   Therefore, the receiver SHOULD repeatedly acknowledge newly received
   packets in preference to packets received in the past.

This should be a design change.

@janaiyengar janaiyengar changed the title Irrelevant normative language in section recommending ack-range limits Fix language in recommendations for ack-range limits Jan 1, 2020
@ianswett
Copy link
Contributor

ianswett commented Jan 2, 2020

I'm not in love with this (entire) section either, but I'd like to better understand this issue.

I agree that sentence is mis-written, though I think the intent was fine.

On the rationale, can you clarify why it does not make sense?

@mnot mnot added -transport editorial An issue that does not affect the design of the protocol; does not require consensus. labels Jan 6, 2020
@janaiyengar janaiyengar self-assigned this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants