Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recovery period definition is odd #3409

Closed
martinthomson opened this issue Feb 4, 2020 · 0 comments · Fixed by #3410
Closed

Recovery period definition is odd #3409

martinthomson opened this issue Feb 4, 2020 · 0 comments · Fixed by #3410
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing

Comments

@martinthomson
Copy link
Member

This is weird in that it assumes some context that isn't provided:

Recovery is a period of time beginning with detection of a lost packet or an increase in the ECN-CE counter. Because QUIC does not retransmit packets, it defines the end of recovery as a packet sent after the start of recovery being acknowledged.

Perhaps instead:

A recovery period is entered when loss or ECN-CE marking of a packet is detected. The recovery period ends when a packet sent during the recovery period is acknowledged.

This "Because QUIC does not retransmit packets" thing is unnecessary. I'll open a PR.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -recovery labels Feb 4, 2020
martinthomson added a commit that referenced this issue Feb 4, 2020
@martinthomson
Redefine recovery period
881369f 
Closes #3409.
@martinthomson martinthomson mentioned this issue Feb 4, 2020
Merged
@mnot mnot added this to Editorial Issues in Late Stage Processing Feb 5, 2020
Late Stage Processing automation moved this from Editorial Issues to Text Incorporated Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing
  
Issue Handled
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redefine recovery period quicwg/base-drafts
1 participant
@martinthomson