Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An example of QUIC section 4.5.1.1 #3549

Closed
kazu-yamamoto opened this issue Mar 28, 2020 · 0 comments · Fixed by #3578
Closed

An example of QUIC section 4.5.1.1 #3549

kazu-yamamoto opened this issue Mar 28, 2020 · 0 comments · Fixed by #3578
Assignees
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@kazu-yamamoto
Copy link
Contributor

For example, if the dynamic table is 100 bytes, then the Required
Insert Count will be encoded modulo 6. If a decoder has received 10
inserts, then an encoded value of 3 indicates that the Required
Insert Count is 9 for the header block.

should be

For example, if the dynamic table is 100 bytes, then the Required
Insert Count will be encoded modulo 6. If a decoder has received 10
inserts, then an encoded value of 4 indicates that the Required
Insert Count is 9 for the header block.

Background:

I implemented ReqInsertCount for decoder.
When I test it with:
MaxTableCapacity = 100
EncodedInsertCount = 3
TotalNumberOfInserts = 10
My function returns 8, not 9.I guess that EncodedInsertCount = 4 is right since ReqInsertCount for encoder calculates 4 with ReqInsertCount = 9.

@tatsuhiro-t pointed out that it looks like the algorithm was replaced, and the example text we are looking at is left as is.

@larseggert larseggert added this to Triage in Late Stage Processing via automation Mar 30, 2020
@larseggert larseggert changed the title An exemple of QUIC section 4.5.1.1 An example of QUIC section 4.5.1.1 Mar 30, 2020
@larseggert larseggert added -qpack editorial An issue that does not affect the design of the protocol; does not require consensus. labels Mar 30, 2020
@project-bot project-bot bot moved this from Triage to Editorial Issues in Late Stage Processing Mar 30, 2020
afrind added a commit that referenced this issue Apr 13, 2020
The algorithm was updated at somepoint but the example was lagging.

Fixes #3549
Late Stage Processing automation moved this from Editorial Issues to Text Incorporated Apr 21, 2020
afrind added a commit that referenced this issue Apr 21, 2020
The algorithm was updated at somepoint but the example was lagging.

Fixes #3549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing
  
Issue Handled
Development

Successfully merging a pull request may close this issue.

3 participants