Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three ECN NiTS #3734

Closed
gorryfair opened this issue Jun 5, 2020 · 0 comments · Fixed by #3747
Closed

Three ECN NiTS #3734

gorryfair opened this issue Jun 5, 2020 · 0 comments · Fixed by #3747
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@gorryfair
Copy link
Contributor

(1) NiT:
/The ECN counter for the ECN codepoint received in the associated IP header are incremented once for each QUIC packet, not per enclosing IP packet or UDP datagram./

  • mixed singular and plural - is this /counters/?

(2) I like this phrase in the security considerations also from the point of view of how to generate transport feedback for ECT(?). Can we call this out here:
/QUIC endpoints ignore the ECN codepoint field on an IP packet unless at least one QUIC packet in that IP packet is successfully processed/

(3) General experiments are not permitted in RFC8311, only using experimental RFCs. I think therefore, we should be clear in the detail here:
/Implementations MAY experiment with and use other strategies for use of ECN. Other methods of probing paths for ECN support are possible, as are different marking strategies. Implementations can also use the ECT(1) codepoint, as specified in {{?RFC8311}}./
I’d propose something more like this:
/Other methods of probing paths for ECN support are possible, as are different marking strategies. Implementations MAY use other methods defined in RFCs, as specified in {{?RFC8311}}. Implementations that use the ECT(1) codepoint, need to perform ECN validation using this code point./

@larseggert larseggert added this to Triage in Late Stage Processing via automation Jun 5, 2020
@martinthomson martinthomson added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Jun 9, 2020
@project-bot project-bot bot moved this from Triage to Editorial Issues in Late Stage Processing Jun 9, 2020
martinthomson added a commit that referenced this issue Jun 9, 2020
Taking Gorry's suggestions here.

Closes #3734.
Late Stage Processing automation moved this from Editorial Issues to Issue Handled Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing
  
Issue Handled
Development

Successfully merging a pull request may close this issue.

3 participants