Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial Fixes for HTTP-QUIC #3815

Closed
Jxck opened this issue Jul 2, 2020 · 2 comments
Closed

Editorial Fixes for HTTP-QUIC #3815

Jxck opened this issue Jul 2, 2020 · 2 comments
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@Jxck
Copy link

Jxck commented Jul 2, 2020

If a client stream terminates without enough of the HTTP message to provide a complete response, the server SHOULD abort its response with the error code H3_REQUEST_INCOMPLETE.

client stream should be clearly written as client initiated stream

If the server sends a partial or complete response but does not abort reading, clients SHOULD continue sending the body of the request and close the stream normally.

the word which pair of send response is receive request, so its better to be does not abort recieving request here for clearify.

@larseggert larseggert added this to Triage in Late Stage Processing via automation Jul 2, 2020
@larseggert larseggert added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Jul 2, 2020
@project-bot project-bot bot moved this from Triage to Editorial Issues in Late Stage Processing Jul 2, 2020
@larseggert larseggert changed the title Editorial Fiexes for HTTP-QUIC Editorial Fixes for HTTP-QUIC Jul 2, 2020
@MikeBishop
Copy link
Contributor

First one is good. The second one is intended to align with Section 2.4 of the transport draft, where "abort reading" is a defined operation on a stream; maybe "does not abort reading the request"?

@Jxck
Copy link
Author

Jxck commented Jul 2, 2020

@MikeBishop > "does not abort reading the request"
SGTM too

MikeBishop added a commit that referenced this issue Jul 9, 2020
Late Stage Processing automation moved this from Editorial Issues to Issue Handled Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing
  
Issue Handled
Development

No branches or pull requests

3 participants