Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What does "commits changes to a state" mean? #3836

Closed
ekr opened this issue Jul 8, 2020 · 0 comments · Fixed by #3869
Closed

What does "commits changes to a state" mean? #3836

ekr opened this issue Jul 8, 2020 · 0 comments · Fixed by #3869
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing

Comments

@ekr
Copy link
Collaborator

ekr commented Jul 8, 2020

S 5.2. says:

Invalid packets without packet protection, such as Initial, Retry, or Version
Negotiation, MAY be discarded. An endpoint MUST generate a connection error if
it commits changes to state before discovering an error.

I'm having trouble parsing this.
@martinthomson martinthomson added -transport editorial An issue that does not affect the design of the protocol; does not require consensus. labels Jul 8, 2020
martinthomson added a commit that referenced this issue Jul 8, 2020
@martinthomson
Clearer explanation of caveat on discarding packets
73c4da7 
Those packets that are not authenticated can be discarded, but only if
processing them has no permanent effect on existing state.  This
attempts to explain that.

Closes #3836.
@martinthomson martinthomson mentioned this issue Jul 8, 2020
Merged
@mnot mnot added this to Triage in Late Stage Processing Jul 9, 2020
@mnot mnot moved this from Triage to Editorial Issues in Late Stage Processing Jul 9, 2020
Late Stage Processing automation moved this from Editorial Issues to Issue Handled Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing
  
Issue Handled
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clearer explanation of caveat on discarding packets quicwg/base-drafts
2 participants
@martinthomson @ekr