Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency about persistent congestion in recovery draft #3899

Closed
kazu-yamamoto opened this issue Jul 13, 2020 · 0 comments · Fixed by #3905
Closed

Inconsistency about persistent congestion in recovery draft #3899

kazu-yamamoto opened this issue Jul 13, 2020 · 0 comments · Fixed by #3905
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing

Comments

@kazu-yamamoto
Copy link
Contributor

In Sec 7.8, the duration of persistent congestion is defined as follows:

(smoothed_rtt + 4 * rttvar + max_ack_delay) * kPersistentCongestionThreshold

However, the pseudo code in B.8 also uses kGranularity:

InPersistentCongestion(lost_packets):
     pto = smoothed_rtt + max(4 * rttvar, kGranularity) + max_ack_delay
     congestion_period = pto * kPersistentCongestionThreshold

I wonder which one is correct.
@LPardue LPardue added this to Triage in Late Stage Processing Jul 14, 2020
@ianswett ianswett added -recovery editorial An issue that does not affect the design of the protocol; does not require consensus. labels Jul 14, 2020
@project-bot project-bot bot moved this from Triage to Editorial Issues in Late Stage Processing Jul 14, 2020
ianswett added a commit that referenced this issue Jul 14, 2020
@ianswett
Use kGranularity in persistent congestion
3800a27 
This aligns the calculation with the PTO calculation, which is what persistent congestion is based off.

Fixes #3899
@ianswett ianswett mentioned this issue Jul 14, 2020
Merged
Late Stage Processing automation moved this from Editorial Issues to Issue Handled Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing
  
Issue Handled
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use kGranularity in persistent congestion quicwg/base-drafts
3 participants
@kazu-yamamoto @LPardue @ianswett