Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it might not be possible to set the DF bit on all systems #4130

Closed
marten-seemann opened this issue Sep 22, 2020 · 3 comments · Fixed by #4140
Closed

it might not be possible to set the DF bit on all systems #4130

marten-seemann opened this issue Sep 22, 2020 · 3 comments · Fixed by #4140
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@marten-seemann
Copy link
Contributor

The QUIC packet size includes the QUIC header and protected payload, but not the UDP or IP headers

For example, OSX doesn't have an API to set this bit (allegedly this will change with Big Sur).
Furthermore, not all implementations might have access to an API that allows them to set bits in the IP header. If I remember correctly, this is one of the reasons we made ECN optional.

@larseggert larseggert added this to Triage in Late Stage Processing via automation Sep 22, 2020
@larseggert
Copy link
Member

I think you wanted to quote this part

UDP datagrams MUST NOT be fragmented at the IP layer. In IPv4
({{!IPv4=RFC0791}}), the DF bit MUST be set to prevent fragmentation on the
path.

Would a proposal be to make the MUST a SHOULD and say "unless this is not supported by the underlying OS"?

@marten-seemann
Copy link
Contributor Author

Yes, that was a weird copy-paste error.
If we say "unless this is not supported by the underlying OS or the programming language" we can probably even keep the MUST.

@janaiyengar
Copy link
Contributor

This is an editorial issue, since the intent of the MUST cannot be to require something that isn't possible.

@janaiyengar janaiyengar added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Sep 23, 2020
@project-bot project-bot bot moved this from Triage to Editorial Issues in Late Stage Processing Sep 23, 2020
Late Stage Processing automation moved this from Editorial Issues to Issue Handled Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing
  
Issue Handled
Development

Successfully merging a pull request may close this issue.

3 participants