-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What units of time you are using #4283
Comments
|
|
@marten-seemann, a max needs to ensure both values use the same units. But provided that they do, I agree. |
Maybe it's easier to say that these are all physical quantities, or numbers with units. In the specification, we use seconds, milliseconds, microseconds. That's fine, because we know how to align the units when we make calculations (e.g., max). |
PR #4263 proposes removing the text in question. Of course, it doesn't matter what time units are in use in this case. I'm fairly confident that where units matter (i.e., we base the value on a constant), the units are explicit. Here, the units are part of the definition of the variables. |
As Martin points out, the offending text was removed. Not seeing anything to be done here , so I'm closing the issue. |
A quick look in the reference did not show what units of time you are using
in the protocol - maybe I missed it?
The text was updated successfully, but these errors were encountered: