Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport: error connection of what #4347

Closed
kazu-yamamoto opened this issue Nov 11, 2020 · 1 comment · Fixed by #4390
Closed

transport: error connection of what #4347

kazu-yamamoto opened this issue Nov 11, 2020 · 1 comment · Fixed by #4390
Labels
-transport ietf-lc An issue that was raised during IETF Last Call.
Projects
Late Stage Processing

Comments

@kazu-yamamoto
Copy link
Contributor

I'm checking "MUST treat" in the transport draft. Sec 17.2.4 says:

Handshake packets MAY contain CONNECTION_CLOSE frames of type 0x1c. Endpoints MUST treat receipt of Handshake packets with other frames as a connection error.

This is only the place where the type of a connection error is NOT specified. This part should be modified as "a connection error of XXX".
@martinthomson
Copy link
Member

This was deliberate, but you can now send CONNECTION_CLOSE in this case, so it makes sense to use a code here.

@larseggert larseggert added -transport ietf-lc An issue that was raised during IETF Last Call. labels Nov 11, 2020
@larseggert larseggert added this to Triage in Late Stage Processing via automation Nov 11, 2020
martinthomson added a commit that referenced this issue Nov 18, 2020
@martinthomson
It's PROTOCOL_VIOLATION
72bf4ca 
Because it always is.

Closes #4347.
@martinthomson martinthomson mentioned this issue Nov 18, 2020
Merged
Late Stage Processing automation moved this from Triage to Issue Handled Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport ietf-lc An issue that was raised during IETF Last Call.
Projects
Late Stage Processing
  
Issue Handled
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

It's PROTOCOL_VIOLATION quicwg/base-drafts
3 participants
@martinthomson @kazu-yamamoto @larseggert