Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barry Leiba's Transport Comment 2 #4559

Closed
LPardue opened this issue Jan 6, 2021 · 2 comments · Fixed by #4602
Closed

Barry Leiba's Transport Comment 2 #4559

LPardue opened this issue Jan 6, 2021 · 2 comments · Fixed by #4602
Labels
-transport iesg An issue raised during IESG review.

Comments

@LPardue
Copy link
Member

LPardue commented Jan 6, 2021

Barry Leiba said:

— Section 9.6.2 —
It SHOULD drop packets
for this connection received on the old IP address, but MAY continue
to process delayed packets.

Do as you think best with cases such as these, but for my part, I dislike the
“SHOULD... but MAY” formulation, as I find it contradictory when it’s read
strictly. In general, I prefer to simply avoid the BCP 14 key word for the
second part (“SHOULD do x, but may make other choices”). In both cases here,
I’d probably just leave off the second part, as it doesn’t seem to add
anything. At the least, I encourage making it “may” (or “can”). But again, as
you think best.

@LPardue LPardue added -transport iesg An issue raised during IESG review. labels Jan 6, 2021
@LPardue LPardue added this to the transport-iesg milestone Jan 6, 2021
@martinthomson
Copy link
Member

The other reference was:

— Section 3.5 —
An endpoint SHOULD copy the error code from the STOP_SENDING frame to
the RESET_STREAM frame it sends, but MAY use any application error
code.

I'm OK with changing to "can".

@janaiyengar
Copy link
Contributor

I don't think we need to do this; I've suggested changes on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport iesg An issue raised during IESG review.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants