Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ben Kaduk's QPACK Comment 4 #4794

Closed
LPardue opened this issue Jan 21, 2021 · 1 comment · Fixed by #4815
Closed

Ben Kaduk's QPACK Comment 4 #4794

LPardue opened this issue Jan 21, 2021 · 1 comment · Fixed by #4815
Labels
-qpack iesg An issue raised during IESG review.
Projects
Late Stage Processing
Milestone
qpack-iesg

Comments

@LPardue
Copy link
Member

LPardue commented Jan 21, 2021

@kaduk said

Appendix A

(nit) At least the plaintext output might benefit from a disclaimer
about line wraps in the 'Value' column being display artifacts.
@LPardue LPardue added -qpack iesg An issue raised during IESG review. labels Jan 21, 2021
@LPardue LPardue added this to the qpack-iesg milestone Jan 21, 2021
@LPardue LPardue added this to Triage in Late Stage Processing via automation Jan 21, 2021
@afrind
Copy link
Contributor

afrind commented Jan 25, 2021

Even though newlines are not really allowed (unescaped) in field values, we can add a note to this effect.

afrind added a commit that referenced this issue Jan 26, 2021
@afrind
QPACK editorial updates from IESG comments
28ce636 
Fixes #4791
Fixes #4792
Fixes #4793
Fixes #4794
Fixes #4797
@afrind afrind mentioned this issue Jan 26, 2021
Merged
Late Stage Processing automation moved this from Triage to Issue Handled Jan 26, 2021
afrind added a commit that referenced this issue Jan 26, 2021
@afrind
QPACK editorial updates from IESG comments
7389b47 
Fixes #4791
Fixes #4792
Fixes #4793
Fixes #4794
Fixes #4797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-qpack iesg An issue raised during IESG review.
Projects
Late Stage Processing
  
Issue Handled
Milestone
qpack-iesg
Development

Successfully merging a pull request may close this issue.

QPACK editorial updates from IESG comments quicwg/base-drafts
2 participants
@LPardue @afrind