Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long and short packet type 00? #487

Closed
larseggert opened this issue Apr 28, 2017 · 6 comments
Closed

Long and short packet type 00? #487

larseggert opened this issue Apr 28, 2017 · 6 comments
Assignees
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@larseggert
Copy link
Member

Packet types start at 01 for packets with both long and short headers.

Is 00 reserved? If yes, the draft should say this and indicate so in the tables.

Or is this a bug and types should start at 00?

@larseggert larseggert added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Apr 28, 2017
@janaiyengar
Copy link
Contributor

janaiyengar commented Apr 28, 2017 via email

@martinthomson
Copy link
Member

I don't think that we want to reserve these. Nor do I think that it needs special mention. We just decided not to use them.

I hear that there are some deployments that route a packet containing a zero octet at the front to other places. I don't think that we need to endorse that sort of behaviour, but avoiding 00 is cheap.

@larseggert
Copy link
Member Author

Well, those deployments are going to have an issue if we ever assign packet type 00. Hence it may be better to reserve? (Or are these deployments also using a custom QUIC version?)

@martinthomson
Copy link
Member

They are currently using a custom version number. Note that we moved the version number field in some pretty strange ways, so those folks will have a whale of a time sorting out an upgrade path.

@janaiyengar
Copy link
Contributor

The case I'm familiar with is not a QUIC version but a different protocol that uses 00 in the first octet on the same port (443) as a classifier. Since it's specific to a listener on port 443 that receives this other protocol and also QUIC packets, it's easier to avoid 00. In general, my thinking is that 00 is always special to someone, and avoiding 00 in the first octet may be good sense.

@martinthomson
Copy link
Member

OBE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

3 participants