Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial nits in quic-tls draft #883

Closed
martinduke opened this issue Oct 18, 2017 · 1 comment
Closed

Editorial nits in quic-tls draft #883

martinduke opened this issue Oct 18, 2017 · 1 comment
Labels
-tls editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@martinduke
Copy link
Contributor

Some things that were unclear when I tried to cleartext encryption from the -07 draft. I am more or less a TLS novice, so YMMV:

  1. Section 5.2.1: For the cleartext secret, it would be useful to state quite clearly here that the connection ID is the "wire image" or "network order" version of connection ID; implementers should not change to host order, etc before calling HKDF-Extract.

  2. Section 5.2.4: "the IV length is the larger of 8 or N_MIN (see section 4 of RFC 5116)". This is super user-unfriendly. At a minimum, we should state that the N_MIN for AES_128_GCM (needed for cleartext) is 12 bytes. At best, we should just list the IV size for supported ciphers.

  3. Section 5.3: "Prior to TLS providing keys, no record protection is performed and the plaintext, P, is transmitted unmodified." I believe this paragraph is obsolete.

@martinthomson martinthomson added -tls editorial An issue that does not affect the design of the protocol; does not require consensus. labels Oct 18, 2017
@martinthomson
Copy link
Member

The wire order thing is being hashed out in #833. An opaque value can only ever be serialized one way, but if we decide that it's a number, then we will merge #881.

martinthomson added a commit that referenced this issue Oct 18, 2017
Remove text about no protection.
Describe the value for N_MIN.

Closes #883
@martinthomson martinthomson mentioned this issue Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-tls editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

2 participants