Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in_flight inconsistency #903

Closed
larseggert opened this issue Oct 27, 2017 · 2 comments
Closed

in_flight inconsistency #903

larseggert opened this issue Oct 27, 2017 · 2 comments
Assignees
@ianswett
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@larseggert
Copy link
Member

larseggert commented Oct 27, 2017 •
edited

OnPacketSentCC is not called for is_ack_only packets, which means that they don't increase bytes_in_flight.

However, when bytes_in_flight is reduced in OnPacketAckedCC and OnPacketsLost, no so such check is performed. This causes bytes_in_flight to eventually go negative.
@martinthomson martinthomson added this to Reliability in QUIC Nov 7, 2017
@mnot mnot added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Dec 12, 2017
@ianswett ianswett self-assigned this Mar 14, 2018
ianswett added a commit that referenced this issue Mar 26, 2018
@ianswett
Fix OnPacketAcked
7376058 
Fixes Issue #903
@ianswett ianswett mentioned this issue Mar 26, 2018
Merged
@ianswett
Copy link
Contributor

The packets_lost issue was fixed by PR #1223 and I just sent out PR #1248 to fix the rest.

@larseggert
Copy link
Member Author

Good to close then

ianswett added a commit that referenced this issue Mar 26, 2018
@ianswett
Fix OnPacketAcked (#1248)
a2e6c8b 
Fixes Issue #903
@mnot mnot removed this from Reliability in QUIC May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianswett ianswett

Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mnot @larseggert @ianswett