Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handshake packets should be retransmitted based on the last sent handshake packet #962

Closed
ianswett opened this issue Nov 28, 2017 · 1 comment
Closed

Handshake packets should be retransmitted based on the last sent handshake packet #962

ianswett opened this issue Nov 28, 2017 · 1 comment
Assignees
@ianswett
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@ianswett
Copy link
Contributor

Instead of using time_of_last_sent_packet, handshake packets should use time_of_last_sent_handshake_packet(to be defined), because if the handshake hasn't completed, protected packets will not be acknowledged, because they cannot be decrypted and processed. The only other valid frames to send pre-handshake are acks and connection close. Acks do not cause an acknowledgement and connection closes are terminal.
@ianswett ianswett added -recovery editorial An issue that does not affect the design of the protocol; does not require consensus. labels Nov 28, 2017
@ianswett ianswett self-assigned this Nov 28, 2017
@ianswett ianswett mentioned this issue Nov 28, 2017
Merged
@siyengar
Copy link

+1, this is a follow up to my comment in your PR?

ianswett added a commit that referenced this issue Mar 6, 2018
@ianswett
Define time_of_last_sent_handshake_packet
37c1aac 
Fixes Issue #962
@ianswett ianswett mentioned this issue Mar 6, 2018
Merged
ianswett added a commit that referenced this issue Mar 12, 2018
@ianswett
Define time_of_last_sent_handshake_packet (#1171)
91caab8 
* Define time_of_last_sent_handshake_packet

Fixes Issue #962

* Update draft-ietf-quic-recovery.md

* Update draft-ietf-quic-recovery.md

* Marten's comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianswett ianswett

Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@siyengar @ianswett