Gratuitous key schedule change #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the labels that we use in key derivations to be shorter. That is in line with similar changes TLS made, so that the number of iterations of the underlying hash function are reduced slightly. QUIC will still run SHA-256 like a bitcoin rig, but this should help some. I've chosen to define the function we use rather than reuse the TLS 1.3 function. It's still the same function, but it now uses a different root label. That should help avoid collisions if QUIC and TLS diverge (though that would be unlikely). The main benefit is in reducing the label length. This also corrects the error in the example.
martinthomson
added
-tls
design
|
Will this change be included in -09? Do we need to do this before or after the remote interim? |
|
It's definitely not in -08. I definitely wouldn't want to make this part of anything we do this month. |
|
@marten-seemann raises a good point -- let's not merge this until after we decide on #995. |
|
PR #995 is no longer in play, so I think we can merge this. |
janaiyengar
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the key schedule for QUIC so that it uses shorter labels. Rather than a "tls13 " stem, it uses a "QUIC " stem. The labels are all now shorter and more consistent in case.
Closes #1003.