Make figures comply with 65-character limit #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
added
-http
-recovery
-tls
editorial
Closed
janaiyengar
approved these changes
Dec 25, 2017
draft-ietf-quic-recovery.md
Outdated
| rttvar = latest_rtt / 2 | ||
| else: | ||
| rttvar = 3/4 * rttvar + 1/4 * | ||
| abs(smoothed_rtt - latest_rtt) |
There was a problem hiding this comment.
how about:
rttvar_sample = abs(smoothed_rtt - latest_rtt)
rttvar = 3/4 * rttvar + 1/4 * rttvar_sample
ianswett
approved these changes
Dec 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for a hopefully-better linting approach, I found that the current linter is actually allowing slightly more characters than it says it is and we have a few longish figure lines. No non-whitespace changes, but in recovery I did have to split two things across lines. Ian, if you'd rather do intermediate calculations here, go for it.