-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text proposal on user land warning about lower layer overhead to addr… #1036
Conversation
"operating system user land" is confusing and seems somewhat colloquial. Also, it doesn't build because you exceed the line length. You should rewrap to 80 characters per line. |
I don't think that this is specific to user space implementations. There are two general classes of concern for user space implementations: timing and MTU. Neither of these are special enough to warrant text (in my opinion). In all cases, there are things that lowers layers of the stack might do to degrade service, either by adding delays or encapsulation. Something like TURN is particularly annoying because the overheads can change over time, but it isn't all that different to a routing change causing packets to be sent on a path with a different MTU (on the contrary, it's actually more predictable). If the intent is to say that you get better performance if you know more about lower layers of the stack, that is a truism. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't care much one way or the other whether we include this, but if so I would suggest the following rephrasing, inserted not in its own section but after the phrase "...1252 octets for IPv4".
"Some QUIC implementations MAY wish to be more conservative in computing allowed QUIC packet size given unknown tunneling overheads or IP header options."
I think that's sufficient, if people would like to see explicit language on this subject.
That might be a better approach. I'd be OK with that. |
@martinduke Okay, lets go with your suggestion. I have updated the pull request to only do that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
Thanks Magus and Martin! |
…ess issue #614