New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak send stream figure #1054
Tweak send stream figure #1054
Conversation
The use of "Application Open" was confusing. The text is clearer on this point, so simplify the diagram. Closes #1008.
draft-ietf-quic-transport.md
Outdated
@@ -2960,7 +2960,7 @@ data to a peer. | |||
|
|||
~~~ | |||
o | |||
| Application Open | |||
| Open Stream | |||
| Open Paired Stream (bidirectional) | |||
v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term "Paired Stream" only appears in the figures. Shouldn't this be Open Unidirectional Stream, Open Bidirectional Stream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Does the latest change work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - sort of - Receive in Send diagram is a bit confusing - but I suppose it means also get ready to receive data.
draft-ietf-quic-transport.md
Outdated
| Application Open | ||
| Open Paired Stream (bidirectional) | ||
| Open Stream | ||
| Open Bidirectional Receive Stream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have the directions flipped (should be Send here and Receive below). Admittedly pedantic, but how about "Open Bidirectional Stream (Sending part)"? Calling it a "Bidirectional Send Stream" sounds silly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is entirely intentional. Opening the receive half of a bidirectional stream causes the send side to open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janaiyengar do you have any suggestions for clarifying this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed the current text is confusing. Open Bidirectional Stream might be clearer.
Is this better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is clearer to me.
The use of "Application Open" was confusing. The text is clearer on this point, so simplify the diagram.
Closes #1008.