Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopted QCRAM draft #1108

Merged
merged 1 commit into from Feb 14, 2018
Merged

Adopted QCRAM draft #1108

merged 1 commit into from Feb 14, 2018

Conversation

afrind
Copy link
Contributor

@afrind afrind commented Feb 13, 2018

Copied the latest from Buck's repo (https://krasic.github.io/draft-krasic-quic-hpack/draft-krasic-quic-qcram.html), made some minor tweaks to the author block and some fixes to pass lint.

@martinthomson
Copy link
Member

This seems OK, but I was expecting a reference from the -http draft to this. Do you think that you could add that? It's not important, we can add that later, of course.

Waiting on chairs to approve adoption before we merge.

Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Martin notes, the chairs need to confirm adoption, but glad to see this finally happen!

@MikeBishop
Copy link
Contributor

MikeBishop commented Feb 13, 2018

I'll add HTTP changes soonish. We can do that as the same or a separate PR.

@krasic
Copy link

krasic commented Feb 14, 2018

Minor nit. Acknowledgements. Redundant to include mbiship@ and afrind@ there?

@larseggert
Copy link
Member

FYI, we confirmed adoption on the list (also for -invariants)

@janaiyengar
Copy link
Contributor

Let's get this doc in and make changes from there. Merging.

@janaiyengar janaiyengar merged commit 5bb4a1e into master Feb 14, 2018
@martinthomson martinthomson deleted the adopt-qcram branch May 29, 2018 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants