Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the 0x8 short header bit for demultiplexing gQUIC #1120

Merged
merged 6 commits into from Mar 5, 2018
Merged

use the 0x8 short header bit for demultiplexing gQUIC #1120

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9593edb
use the 0x8 short header bit for demultiplexing gQUIC
marten-seemann Feb 21, 2018
4413a91
add note to RFC editor
marten-seemann Feb 21, 2018
b077776
Ian's comment
marten-seemann Feb 23, 2018
379be9b
start short header packet types from 0
marten-seemann Mar 5, 2018
ac30fd9
change editor's note
marten-seemann Mar 5, 2018
9d5867a
add text about the fourth bit
marten-seemann Mar 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -486,6 +486,9 @@ Key Phase Bit:
recipient of a packet to identify the packet protection keys that are used to
protect the packet. See {{QUIC-TLS}} for details.

\[\[RFC editor: please remove the Google QUIC Demultipexing bit before
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnot suggests that we make this a simple editors note and that it say:

\[\[Editor's Note: this section should be removed and the bit definitions changed before this draft goes to the IESG.]]

publication.]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity, we don't want them to actually eliminate the bit, just the text describing why it's there. I'd just steal the Note from the changelog asking that "this section" be removed, and put it immediately after (rather than before) the header.


Google QUIC Demultipexing Bit:

: The fifth bit (0x8) of octet 0 is set to 0. This allows implementations of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to mention the fourth bit also.

Expand Down