Reference RFC5681 and RFC6928 #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially fixes #592
gloinul
reviewed
Mar 22, 2018
draft-ietf-quic-recovery.md
Outdated
| kMinimumWindow (default 2 * kDefaultMss): | ||
| : Default minimum congestion window. | ||
| kInitialWindow (default 14600 bytes): | ||
| : Default limit on the initial amount of outstanding data in bytes. |
There was a problem hiding this comment.
I would note that RFC 6928 states the following as the TCP initial window:
More precisely, the upper bound for the initial window will be
min (10*MSS, max (2*MSS, 14600)) (1)
I would recommend that one do calculate this value for the Initial value, as MSS may be based on a 9K MTU, thus allowing two full packets in those cases.
There was a problem hiding this comment.
Also if mss is smaller than 1460 then more than 10 packets can be sent. Is that intentional? I am slightly worried about packet bursts. Are there a pacing requirement?
janaiyengar
reviewed
Mar 27, 2018
draft-ietf-quic-recovery.md
Outdated
| @@ -974,6 +968,13 @@ kLossReductionFactor (default 0.5): | |||
| Variables required to implement the congestion control mechanisms | |||
| are described in this section. | |||
|
|
|||
| sender_mss: | |||
There was a problem hiding this comment.
I don't think we should use MSS, since the idea of a segment is TCP-specific. How about max_datagram_size?
|
@ianswett, I leave this with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #592 and #1102