Swap payload length #1294
Merged
Swap payload length #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I strongly recommend to modify 1079 in a way that does not modify any AEAD protected content at all, and that means moving the packet number further away. But even without moving the packet number, it is possible to encrypt only the packet number without afffecting neighbouring fields using my proposed changes. |
|
Yeah, this is what I planned to do when rebasing #1079. No sense in delaying it given that Christian has done the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps the positions of the payload length and packet number field in the long header. This will allow encryption of the packet number per PR #1079 without also encrypting the payload length at the same time. Because encrypting the payload length makes packet handling really complicated!