Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/initial_max_stream_id_(uni|bidi)/initial_max_streams_$1/g #1310

Merged
merged 2 commits into from Apr 25, 2018
Merged

s/initial_max_stream_id_(uni|bidi)/initial_max_streams_$1/g #1310

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa63065
s/initial_max_stream_id_(uni|bidi)/initial_max_streams_$1/g
Apr 20, 2018
55b8da1
Mike's comment
janaiyengar Apr 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 9 additions & 9 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -1125,12 +1125,12 @@ language from Section 3 of {{!I-D.ietf-tls-tls13}}.
enum {
initial_max_stream_data(0),
initial_max_data(1),
initial_max_streams_bidi(2),
initial_max_bidi_streams(2),
idle_timeout(3),
max_packet_size(5),
stateless_reset_token(6),
ack_delay_exponent(7),
initial_max_streams_uni(8),
initial_max_uni_streams(8),
(65535)
} TransportParameterId;

Expand Down Expand Up @@ -1199,7 +1199,7 @@ idle_timeout (0x0003):

An endpoint MAY use the following transport parameters:

initial_max_streams_bidi (0x0002):
initial_max_bidi_streams (0x0002):

: The initial maximum bidirectional streams parameter contains the initial
maximum number of application-owned bidirectional streams the peer may
Expand All @@ -1213,7 +1213,7 @@ initial_max_streams_bidi (0x0002):
equivalent to receiving a MAX_STREAM_ID containing 20 when received by a
client or 17 when received by a server.

initial_max_streams_uni (0x0008):
initial_max_uni_streams (0x0008):

: The initial maximum unidirectional streams parameter contains the initial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the expansion is "initial maximum unidirectional streams", perhaps this should be "initial_max_uni_streams" instead, and likewise for bidi?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. That sounds better.

maximum number of application-owned unidirectional streams the peer may
Expand Down Expand Up @@ -1275,12 +1275,12 @@ might be violated by the client with its 0-RTT data. In particular, a server
that accepts 0-RTT data MUST NOT set values for initial_max_data or
initial_max_stream_data that are smaller than the remembered value of those
parameters. Similarly, a server MUST NOT reduce the value of
initial_max_streams_bidi or initial_max_streams_uni.
initial_max_bidi_streams or initial_max_uni_streams.

Omitting or setting a zero value for certain transport parameters can result in
0-RTT data being enabled, but not usable. The following transport parameters
SHOULD be set to non-zero values for 0-RTT: initial_max_streams_bidi,
initial_max_streams_uni, initial_max_data, initial_max_stream_data.
SHOULD be set to non-zero values for 0-RTT: initial_max_bidi_streams,
initial_max_uni_streams, initial_max_data, initial_max_stream_data.

A server MUST reject 0-RTT data or even abort a handshake if the implied values
for transport parameters cannot be supported.
Expand Down Expand Up @@ -4097,12 +4097,12 @@ The initial contents of this registry are shown in {{iana-tp-table}}.
|:-------|:---------------------------|:------------------------------------|
| 0x0000 | initial_max_stream_data | {{transport-parameter-definitions}} |
| 0x0001 | initial_max_data | {{transport-parameter-definitions}} |
| 0x0002 | initial_max_streams_bidi | {{transport-parameter-definitions}} |
| 0x0002 | initial_max_bidi_streams | {{transport-parameter-definitions}} |
| 0x0003 | idle_timeout | {{transport-parameter-definitions}} |
| 0x0005 | max_packet_size | {{transport-parameter-definitions}} |
| 0x0006 | stateless_reset_token | {{transport-parameter-definitions}} |
| 0x0007 | ack_delay_exponent | {{transport-parameter-definitions}} |
| 0x0008 | initial_max_streams_uni | {{transport-parameter-definitions}} |
| 0x0008 | initial_max_uni_streams | {{transport-parameter-definitions}} |
{: #iana-tp-table title="Initial QUIC Transport Parameters Entries"}


Expand Down