Deemphasize TCP SACKs reference in ACK frame description #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is odd to describe something by saying what is *not* like. In addition, not all readers of the document will be familiar with TCP SACKs.
martinthomson
requested changes
Apr 24, 2018
draft-ietf-quic-transport.md
Outdated
| Unlike TCP SACKs, QUIC acknowledgements are irrevocable. Once a packet has | ||
| been acknowledged, even if it does not appear in a future ACK frame, | ||
| it remains acknowledged. | ||
| QUIC acknowledgements are irrevocable: Once a packet has been acknowledged, |
draft-ietf-quic-transport.md
Outdated
| it remains acknowledged. | ||
| QUIC acknowledgements are irrevocable: Once a packet has been acknowledged, | ||
| even if it does not appear in a future ACK frame, it remains acknowledged. | ||
| (This is unlike TCP SACKs.) |
There was a problem hiding this comment.
Don't include an entire sentence in a parenthetical. It would be fine to remove the paretheses here.
Of course, now that you touched this, I notice that we don't have a TCP SACK reference here, and you can't just use an unexpanded acronym like this without both expansion and a reference.
ianswett
approved these changes
Apr 25, 2018
janaiyengar
approved these changes
Apr 25, 2018
|
I think this addresses Martin's comments, so I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is odd to describe something by saying what is not like. In
addition, not all readers of the document will be familiar with
TCP SACKs.