Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retransmit data, not packets #1327

Merged
merged 1 commit into from Apr 25, 2018
Merged

Retransmit data, not packets #1327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion draft-ietf-quic-recovery.md
View file
Open in desktop
Expand Up @@ -496,7 +496,7 @@ loss_detection_alarm:
: Multi-modal alarm used for loss detection.

handshake_count:
: The number of times the handshake packets have been
: The number of times all unacknowledged handshake data has been
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The number of times all unacknowledged handshake data has been transmitted"

without receiving an ack seems redundant :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's consistent with tlp_count and rto_count because all get reset to 0 when an ack is received.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the point is that "unacknowledged ... without receiving an ack" is either redundant (if it's unacknowledged, of course you didn't receive an ack) or ambiguous (without receiving an ack of that data, or without receiving any acks for anything?) depending how you read it.

And if it occurs multiple places, we can fix it multiple places. ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's without receiving an ack for any new packets. Does that deserve clarification in all 3 spots?

retransmitted without receiving an ack.

tlp_count:
Expand Down