Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds subheadings for post-base instructions #1366

Merged
merged 1 commit into from May 25, 2018
Merged

Adds subheadings for post-base instructions #1366

merged 1 commit into from May 25, 2018

Conversation

martinthomson
Copy link
Member

These are different enough that they deserve a heading. And some fixups on the diagrams.

@martinthomson
Adds subheadings for post-base instructions
d89fba7 
These are different enough that they deserve a heading.  And some fixups on the diagrams.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -qpack labels May 21, 2018
MikeBishop
MikeBishop reviewed May 22, 2018
View reviewed changes
Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had intentionally been trying to keep these grouped, because they're logically the same, just with different indexing. I'm not averse to separating them out either, but the old style was deliberate.

afrind
afrind approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@afrind afrind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as long as they are right next to each other they're grouped enough.

@afrind
Copy link
Contributor

afrind commented May 22, 2018

Or subhead one more level since the text is really subordinate to the preceding instruction?

@martinthomson
Copy link
Member Author

Note that h4 (four '#') is already below the waterline for our ToC. h3 should be the goal.

@afrind afrind merged commit adb73bf into master May 25, 2018
@martinthomson martinthomson deleted the post-base-indexed branch May 29, 2018 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeBishop MikeBishop MikeBishop left review comments

@afrind afrind afrind approved these changes

Assignees
No one assigned
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martinthomson @afrind @MikeBishop