Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword linkability on migration text #1369

Merged
merged 2 commits into from May 23, 2018
Merged

Reword linkability on migration text #1369

merged 2 commits into from May 23, 2018

Conversation

martinthomson
Copy link
Member

Closes #1364.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels May 22, 2018
activity from the same connection on different networks. Protection of packet
numbers ensures that packet numbers cannot be used to correlate activity. Other
properties of packets, such as timing and size, might be used to correlate
activity, but these changes ensure that the packet header cannot be used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"but these changes" is a bit vague - how about "but using a path unique connection ID enures ..."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I agree with @mikkelfj, "but these changes" is loose text and wont stand well after another change or three.

@martinthomson martinthomson merged commit 3d089d0 into master May 23, 2018
@martinthomson martinthomson deleted the that-to-break branch May 29, 2018 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants