New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for adding ECN support to QUIC. #1372
Merged
Merged
Changes from 3 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
961d5d9
According to text in wiki. Some MD fixes to get right formating.
gloinul b50fe18
Modified proposed text to integrate better and take care of issues ar…
gloinul 57278fe
Fixed a typo on anchor creation
gloinul 44a70f8
According to text in wiki. Some MD fixes to get right formating.
gloinul afd15f2
Modified proposed text to integrate better and take care of issues ar…
gloinul da68127
Fixed a typo on anchor creation
gloinul a9755ce
Merge branch 'ecn' of https://github.com/gloinul/base-drafts into ecn
gloinul 3a95c40
Clarified that ACK or ACK_ECN can be used for acknowledgment in hands…
gloinul 12b1054
Added ECN intro paragraph. Various editorial improvements of ECN text.
gloinul bfe80d5
Fixed bullet list, Added parenthis around section refs.
gloinul 88f76dc
Fixed indentation and formating
gloinul f14134f
Spelling fixed
gloinul 71c2794
Rewrote the ECN check algorithm for connection migration to be robust.
gloinul 2ff5ac9
Removed trailing spaces.
gloinul 19d3b53
Fixed trailing spaces in recovery.
gloinul f71e933
Rewraped text in both recovery and transport. Added a new sub-section…
gloinul fc94546
Added textual description of ECN-CE indicating congestion events.
gloinul 66505a3
Editorial fixes
martinthomson d525046
Merge pull request #1 from quicwg/ecn
gloinul 28ef4c1
Editing some formulations. Rewraping more text
gloinul 6dd9237
Fixed trailing spaces and remaining line length issues, I hope.
gloinul 0bb5bad
Reflowing now saved
gloinul 0f94847
Merge branch 'master' of https://github.com/quicwg/base-drafts into ecn
gloinul 0e7d43b
Merge branch 'master' of https://github.com/quicwg/base-drafts into ecn
gloinul 822aded
Changed so that additional ECN-CE marks are sent in immediate ACKs to…
gloinul 345f593
Fixed lint issues
gloinul e60cc8f
Adding security consideration around ECN into transport.
gloinul fdf9df7
Reverting some rewrapping that are not necessary to reduce clutter.
gloinul ec97fd8
Addressing issues raised by Ian Sweet on 180611. Editorial improvemen…
gloinul bf30190
Clarifying that both cases are capability checks. Correcting a number…
gloinul 60468a7
Fixed a too too much
gloinul f577c8e
Addressing Martin Thomson's comments. Several editorial changes. The …
gloinul 2d76935
Added paragraph on dealing with persistent loss of acknowledgement of…
gloinul 4af108c
Fixing typo in new paragraph.
gloinul 55fa3d6
Merge branch 'master' of https://github.com/quicwg/base-drafts into ecn
gloinul e06a2a0
Added requirement on ECN marking suppression for packet duplicates.
gloinul 1636ebc
Clarifying that idefinite state are not requeired in duplication dete…
gloinul 139f1ee
Martin Thomson's editorial suggestions. Restructured pseudo code sect…
gloinul dbfe4d8
partial editorial fixes
janaiyengar 73bf8cb
Merge pull request #2 from janaiyengar/ecn
gloinul be91e8f
Moved the ECN block in the ACK prior to the ACK blocks themselves. Re…
gloinul f8d3d5c
Merge branch 'ecn' of https://github.com/gloinul/base-drafts into ecn
gloinul cf312f9
Merged ECN counters into single ACK frame section and move them befor…
gloinul File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -418,9 +418,9 @@ when it receives a new packet which is not one greater than the | |
largest received packet number. | ||
|
||
Also, reception of an packet marked as ECN Congestion Experience (ECN-CE) | ||
SHOULD be acknowledged more quickly to quicker react to congesiton events. | ||
Additional ECN-CE marks received during the same recovery period does | ||
not need to be immediately acknowledged, see {{congestion-ecn}}. | ||
SHOULD be acknowledged immediately to quicker react to congesiton events. | ||
Additional ECN-CE marks received during the same recovery period are also | ||
immediately acknowledged to correctly account for ECN-CE marks in the recovery period. | ||
|
||
As an optimization, a receiver MAY process multiple packets before | ||
sending any ACK frames in response. In this case they can determine | ||
|
@@ -894,14 +894,14 @@ in {{tlp}} and {{rto}}. | |
|
||
If ECN {!RFC3168} has been verified to work for the current path QUIC | ||
will use the ECN Congestion Experienced (ECN-CE) IP packet marking as a | ||
signal of congestion as a complement to paket loss. This document | ||
signal of congestion as a complement to packet loss. This document | ||
specifies to use the classical ECN-CE response, i.e. the same response | ||
as for packet loss. However, there exist potenatial for future | ||
as for packet loss. However, there exist potential for future | ||
experimentation in using other response functions as discussed in | ||
{!RFC8311}. | ||
|
||
The ACK_ECN frame defined in {{QUIC-TRANSPORT}} does not provide | ||
information on which of the newely acknowledged packets that | ||
information on which of the newly acknowledged packets that | ||
was marked with ECN-CE. Therefore, it will be assumed that | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would suggest rewriting as: "Because newly received marks cause an ACK_ECN be sent immediately, is is assumed the congestion event starts at the highest newly acknowledged packet number." |
||
the congestion event starts at the highest acknowledged packet | ||
number. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove "that"