Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the packet number encryption sampling clearer #1389

Merged
merged 5 commits into from May 29, 2018
Merged

Make the packet number encryption sampling clearer #1389

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
edff824
Make the packet number encryption sampling clearer
martinthomson May 25, 2018
5b81241
Include packet number in the length field for long headers
martinthomson May 25, 2018
c408ba4
Missed version
martinthomson May 25, 2018
10df2ab
Rephrase the description of sampled ciphertext
martinthomson May 25, 2018
0cdfe02
Remove either
martinthomson May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion draft-ietf-quic-tls.md
View file
Open in desktop
Expand Up @@ -958,7 +958,7 @@ QUIC packets might be included in the same UDP datagram and that each one is
handled separately.

~~~
sample_offset = min(2 + len(destination_connection_id) +
sample_offset = min(6 + len(destination_connection_id) +
len(source_connection_id) +
len(payload_length) + 4,
packet_length - aead_expansion)
Copy link
Member

@nibanks nibanks May 25, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume packet_length refers to the QUIC packet length and not the UDP payload length, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I see the problem. You don't know where the payload length starts. It seems like we need to make the payload length cover the packet number length. More changes inbound.

Expand Down