Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream0 dt output for merge #1450

Merged
merged 35 commits into from
Jun 25, 2018
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
42f55df
Output of Stream 0 Design Team.
ekr May 23, 2018
cab8295
Fix changelog
ekr May 23, 2018
984ecc8
Fix whitespace
ekr May 23, 2018
36899e5
Offset and length fields in CRYPTO_HS are not optional
ekr May 23, 2018
f8f172f
Remove EMPTY_ACK
ianswett Jun 6, 2018
70b26e8
Incorporate the comments from PR#1377
ekr Jun 6, 2018
af70f23
Remove EMPTY_ACK
ianswett Jun 6, 2018
aa1b683
Update draft-ietf-quic-transport.md
ianswett Jun 6, 2018
927cf12
Add the TLS diagrams
ekr Jun 7, 2018
74300a1
Redact diagram from the TLS doc
ekr Jun 7, 2018
04fd321
Ian Swett's comments
ekr Jun 7, 2018
bf9c62c
server-initiated streams start from 1
ekr Jun 7, 2018
77155f9
Remove last TODO
ekr Jun 8, 2018
779b3a0
Minor editorial
ekr Jun 15, 2018
d3b055a
Remove the advice on how to use coalesced packets for recovery.
ekr Jun 15, 2018
48c9b9f
Self-review, ready to submit
ekr Jun 15, 2018
396c318
Some more cleanup
ekr Jun 15, 2018
777114a
Fix compile errors
ekr Jun 15, 2018
a4ad49b
Restore Generating Acknowledgements
ianswett Jun 18, 2018
6b36300
Mike's comments
ianswett Jun 19, 2018
0cfdf67
Merge pull request #34 from ekr/ianswett-mike-comments
ekr Jun 19, 2018
4065266
Fix retry and remove optimizations
ianswett Jun 19, 2018
954c585
Merge pull request #35 from ekr/ianswett-mike2
ekr Jun 19, 2018
d814642
Martin's comments
ianswett Jun 20, 2018
da0d8ec
Ensures that
ianswett Jun 21, 2018
89c45a6
Merge pull request #36 from ekr/ianswett-martin
ekr Jun 21, 2018
daea861
Address MT's comments on TLS
ekr Jun 21, 2018
3aea50d
MT/Bishop comments on transport
ekr Jun 22, 2018
bd5f9ff
Ian's comments
ekr Jun 22, 2018
e2ed4db
Merge pull request #37 from ekr/martins_comments
ekr Jun 22, 2018
7a780db
Fix build breaks
MikeBishop Jun 22, 2018
4db5568
Extra word
MikeBishop Jun 22, 2018
8d57711
remove "the the"
martinthomson Jun 25, 2018
a2aabfe
More errors around delivering to TLS out of order
martinthomson Jun 25, 2018
2473966
The online editor is terrible
martinthomson Jun 25, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions draft-ietf-quic-recovery.md
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,30 @@ containing CRYPTO_HS frames should use a very short ack delay, such as 1ms.
ACK frames may be sent immediately when the crypto stack indicates all
data for that encryption level has been received.

## Generating Acknowledgements

QUIC SHOULD delay sending acknowledgements in response to packets,
but MUST NOT excessively delay acknowledgements of packets containing
non-ack frames. Specifically, implementaions MUST attempt to
enforce a maximum ack delay to avoid causing the peer spurious
timeouts. The default maximum ack delay in QUIC is 25ms.

An acknowledgement MAY be sent for every second full-sized packet,
as TCP does {{?RFC5681}}, or may be sent less frequently, as long as
the delay does not exceed the maximum ack delay. QUIC recovery algorithms
do not assume the peer generates an acknowledgement immediately when
receiving a second full-sized packet.

Out-of-order packets SHOULD be acknowledged more quickly, in order
to accelerate loss recovery. The receiver SHOULD send an immediate ACK
when it receives a new packet which is not one greater than the
largest received packet number.

As an optimization, a receiver MAY process multiple packets before
sending any ACK frames in response. In this case they can determine
whether an immediate or delayed acknowledgement should be generated
after processing incoming packets.

### ACK Ranges

When an ACK frame is sent, one or more ranges of acknowledged packets are
Expand Down